Skip to content

create regular PRs for main-vs-deps insertion#63243

Merged
dibarbet merged 1 commit intodotnet:mainfrom
dibarbet:174p2_undraft
Aug 6, 2022
Merged

create regular PRs for main-vs-deps insertion#63243
dibarbet merged 1 commit intodotnet:mainfrom
dibarbet:174p2_undraft

Conversation

@dibarbet
Copy link
Copy Markdown
Member

@dibarbet dibarbet commented Aug 5, 2022

No description provided.

@dibarbet dibarbet requested a review from a team as a code owner August 5, 2022 21:11
@ghost ghost added the Area-Infrastructure label Aug 5, 2022
"vsBranch": "main",
"vsMajorVersion": 17,
"insertionCreateDraftPR": true,
"insertionCreateDraftPR": false,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this accidentally changed or is this a workflow change for us? Obviously do what works for you, just curious if we changing flow here.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is normal - I think we just missed flipping it back from draft when VS main switched to 17.4p2

@dibarbet dibarbet merged commit 2880b0a into dotnet:main Aug 6, 2022
@dibarbet dibarbet deleted the 174p2_undraft branch August 6, 2022 00:33
@ghost ghost added this to the Next milestone Aug 6, 2022
@dibarbet dibarbet modified the milestones: Next, 17.4 P2 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants