Merged
Conversation
a6a2056 to
c814594
Compare
Member
Author
|
@jasonmalinowski PTAL |
jasonmalinowski
approved these changes
Aug 5, 2022
| return ImmutableArray<TodoCommentDescriptor>.Empty; | ||
|
|
||
| var tuples = data.Split('|'); | ||
| using var _ = ArrayBuilder<TodoCommentDescriptor>.GetInstance(out var result); |
Member
There was a problem hiding this comment.
Nit, but we can we pass capacity? (This probaby runs rarely enough to matter though.)
Member
There was a problem hiding this comment.
(Feel free to ignore unless you have to make some other edit.)
src/Features/LanguageServer/Protocol/Features/TodoComments/TodoCommentOptionsStorage.cs
Show resolved
Hide resolved
| } | ||
|
|
||
| public static ImmutableArray<TodoCommentDescriptor> Parse(string data) | ||
| public static ImmutableArray<TodoCommentDescriptor> Parse(ImmutableArray<string> items) |
Member
There was a problem hiding this comment.
https://github.com/xamarin/vsmac/pull/8604 would indicate that TypeScript has IVT usage of this. Will try to confirm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces CommentTaskTokenSerializer specialized option provider with standard RoamingProfileStorageLocation storage that reads the options using
ISettingManager.There is an oddity with how this option is stored in the Settings Manager. If the option is read as
objectthe Settings Manager returns Newtonsoft.Json's JArray object. To avoid taking dependency on this type we explicitly query forstring[]. If we do so we get backstring[]that we can use directly.Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1585190