Conversation
e846955 to
055eeca
Compare
| get => _additionalFilterTexts; | ||
| set | ||
| { | ||
| Debug.Assert(!value.IsDefault && (value.IsEmpty || HasDifferentFilterText), |
There was a problem hiding this comment.
I like this designation, makes sense to me.
404d62b to
16a65e8
Compare
|
@akhera99 @genlu we should think about a proposal for the LSP spec as well, currently they only have a single filterText field |
|
@dibarbet Sure, what's the process of making such a proposal? |
|
@genlu we can file an issue on the LSP area path in ADO and ping Jose to bring to to an LSP sync meeting. We should bring a general outline of what we think the additional properties would look like and how they'd function Once we've implemented it internally in the VS client and server we can consider porting to the public spec. |
|
Sure will do.
The scenario that requires AdditionalFIiterTexts seems to be very limited at the moment, and everything that do require it is internal, so I'm a little concerned if this is something we want to publicly expose (until at least snippets and AdditionalFIiterTexts are made public). My hesitance is also because right now the UX for items matched with AdditionalFIiterText isn't great, we make a best effort attempt to highlight base on the display text, but if we don't find a match there, it might be unclear to users why the item is being selected/available. |
Here's an example. The snippet is changed to has "cw" as regular
FilterText, and "Console" and "WriteLine" asAdditionalFilterTexts