Skip to content

Remove bogus assert around C# import scopes.#63146

Merged
CyrusNajmabadi merged 4 commits intodotnet:mainfrom
CyrusNajmabadi:interactiveImportScopes
Aug 5, 2022
Merged

Remove bogus assert around C# import scopes.#63146
CyrusNajmabadi merged 4 commits intodotnet:mainfrom
CyrusNajmabadi:interactiveImportScopes

Conversation

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

Fixes #63144

@CyrusNajmabadi CyrusNajmabadi requested review from a team as code owners August 2, 2022 21:34
@ghost ghost added the Area-Compilers label Aug 2, 2022
@CyrusNajmabadi
Copy link
Copy Markdown
Contributor Author

@dotnet/roslyn-compiler can you look at this one line removal of an overly aggressive assert?

@CyrusNajmabadi CyrusNajmabadi disabled auto-merge August 3, 2022 00:09
@CyrusNajmabadi CyrusNajmabadi enabled auto-merge (squash) August 3, 2022 00:09
@CyrusNajmabadi CyrusNajmabadi merged commit 532035e into dotnet:main Aug 5, 2022
@ghost ghost added this to the Next milestone Aug 5, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the interactiveImportScopes branch August 5, 2022 19:06
@dibarbet dibarbet modified the milestones: Next, 17.4 P2 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assertion in CSharpSemanticModel.GetImportScopesCore fails in Interactive Window

5 participants