Add checks to ensure that we don't have any unexpected exceptions corrupting state#63133
Merged
CyrusNajmabadi merged 3 commits intodotnet:mainfrom Aug 2, 2022
Merged
Conversation
CyrusNajmabadi
commented
Aug 2, 2022
| assetProvider, solutionChecksum, workspaceVersion, updatePrimaryBranch); | ||
| solutionTask = inFlightSolution.PreferredSolutionTask_NoLock; | ||
| await DecrementInFlightCountAsync(inFlightSolution).ConfigureAwait(false); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
broke this code into 3 helpers:
- acquire the solution. this updates state and has checks to make sure that happens successfully. It must always run to completion.
- process the solution. this is allowed to technically fail for any reason (and cancellation failure is totally ok). failure must not leave this type in an inconsistent state.
- cleanup. this updates state and has checks to make sure that happens successfully. It must always run to completion.
dibarbet
approved these changes
Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #63132