Simplify construction of hte RemoteWorkspace#63112
Merged
CyrusNajmabadi merged 2 commits intodotnet:mainfrom Aug 2, 2022
Merged
Simplify construction of hte RemoteWorkspace#63112CyrusNajmabadi merged 2 commits intodotnet:mainfrom
CyrusNajmabadi merged 2 commits intodotnet:mainfrom
Conversation
genlu
approved these changes
Aug 1, 2022
tmat
reviewed
Aug 1, 2022
| internal RemoteWorkspace(HostServices hostServices, string? workspaceKind) | ||
| : base(hostServices, workspaceKind) | ||
| internal RemoteWorkspace(HostServices hostServices) | ||
| : base(hostServices, WorkspaceKind.RemoteWorkspace) |
Member
Contributor
Author
There was a problem hiding this comment.
ideally, RemoteWorkspace will go away. Since we don't want anything on OOP to even be able to go from solution->Workspace anymore, and there's no way to mutate things in OOP.
This is one of those PRs in the "help cyrus poke around this space to learn what is going on and what unknown unknowns exist" space.
Member
There was a problem hiding this comment.
Would we return null from Solution.Workspace then?
Contributor
Author
There was a problem hiding this comment.
that, or just throwing. i'm experimenting with that in another branch right now. we would at least 'ban' it. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.