Avoid intermediary array allocation when computing checksums#63109
Merged
CyrusNajmabadi merged 7 commits intodotnet:mainfrom Aug 2, 2022
Merged
Avoid intermediary array allocation when computing checksums#63109CyrusNajmabadi merged 7 commits intodotnet:mainfrom
CyrusNajmabadi merged 7 commits intodotnet:mainfrom
Conversation
CyrusNajmabadi
commented
Aug 1, 2022
| var metadataReferenceChecksums = ChecksumCache.GetOrCreate<ChecksumCollection>(MetadataReferences, _ => new ChecksumCollection(MetadataReferences.SelectAsArray(r => serializer.CreateChecksum(r, cancellationToken)))); | ||
| var analyzerReferenceChecksums = ChecksumCache.GetOrCreate<ChecksumCollection>(AnalyzerReferences, _ => new ChecksumCollection(AnalyzerReferences.SelectAsArray(r => serializer.CreateChecksum(r, cancellationToken)))); | ||
|
|
||
| var documentChecksums = await Task.WhenAll(documentChecksumsTasks).ConfigureAwait(false); |
Contributor
Author
There was a problem hiding this comment.
this would make an array, that we would then copy over to an immutable array below. the new code avoids that intermediary array allocation.
CyrusNajmabadi
commented
Aug 1, 2022
| foreach (var task in tasks) | ||
| result.Add(await task.ConfigureAwait(false)); | ||
|
|
||
| return result.ToImmutableAndClear(); |
Contributor
Author
There was a problem hiding this comment.
ToImmutableAndClear allows for an underlying call to MoveToImmutable. We likely should always be using it if we use the GetInstance form that takes a count. I'll open another PR on that.
genlu
approved these changes
Aug 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.