Add IOperation test where IObjectCreationOperation.Constructor is null#63092
Merged
333fred merged 2 commits intodotnet:mainfrom Oct 21, 2022
Merged
Add IOperation test where IObjectCreationOperation.Constructor is null#63092333fred merged 2 commits intodotnet:mainfrom
333fred merged 2 commits intodotnet:mainfrom
Conversation
333fred
approved these changes
Aug 2, 2022
Member
333fred
left a comment
There was a problem hiding this comment.
LGTM (commit 1). @dotnet/roslyn-compiler for a second review.
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
2 tasks
AlekseyTs
reviewed
Oct 20, 2022
| M(New C.S())'BIND:"New C.S()" | ||
| End Sub | ||
| End Class]]>.Value | ||
| Dim expectedDiagnostics = <![CDATA[ |
Contributor
auto-merge was automatically disabled
October 21, 2022 05:43
Head branch was pushed to by a user without write access
Member
|
Thanks @Youssef1313! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was no IOperation tests covering this case for VB.
For C#, it doesn't look like constructor can be null, so I added an assert.