Small pieces of rename serialization cleanup#63066
Small pieces of rename serialization cleanup#63066CyrusNajmabadi merged 2 commits intodotnet:mainfrom
Conversation
|
|
||
| return result.Dehydrate(); | ||
| var renameLocations = await SymbolicRenameLocations.FindLocationsInCurrentProcessAsync( | ||
| symbol, solution, options, GetClientOptionsProvider(callbackId), cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
there was no point jumping to LightweightRenameLocations on the oop side. it exists on the host side as a temporary data so we can call back into oop efficiently without rehydrating symbols. THe previous code would make the LightweightRenameLocations then immediately convert that to SymbolicRenameLocations. so this just bypasses that.
There was a problem hiding this comment.
Is it possible we can annotate types that shouldn't be used in OOP/Not OOP locations based on folder paths? I assume outside of serialization everything in ServiceHub/* doesn't need to use serializable data.
There was a problem hiding this comment.
Definitely an good idea! :)
|
|
||
| var locations = await LightweightRenameLocations.TryRehydrateAsync( | ||
| solution, GetClientOptionsProvider(callbackId), serializableLocations, cancellationToken).ConfigureAwait(false); | ||
| if (locations == null) |
There was a problem hiding this comment.
similarly, we should not be going through LightweightRenameLocations on the oop side.
Fallout after moving rename to have a more lightweight form of serialization when processing. Something i also want to pull out of a different, more complex, rename oop PR.