Auto-default ref fields with a null ref-assignment#63065
Merged
jaredpar merged 5 commits intodotnet:mainfrom Aug 9, 2022
Merged
Auto-default ref fields with a null ref-assignment#63065jaredpar merged 5 commits intodotnet:mainfrom
jaredpar merged 5 commits intodotnet:mainfrom
Conversation
cston
reviewed
Jul 29, 2022
| } | ||
|
|
||
| [Fact, WorkItem(63018, "https://github.com/dotnet/roslyn/issues/63018")] | ||
| public void InitRefField_AutoDefault() |
Contributor
There was a problem hiding this comment.
Consider moving above ScopedReserved_* tests, to avoid a conflict with #62783. #Resolved
cston
approved these changes
Jul 29, 2022
cston
approved these changes
Jul 29, 2022
Member
Author
|
@cston FYI, I skipped one test following integration with runtime flag change (that test needs to use Net60 framework and use the test hook...). |
Member
Author
|
@dotnet/roslyn-compiler for second review. Thanks |
Member
Author
|
@dotnet/roslyn-compiler for second review. Thanks |
jaredpar
approved these changes
Aug 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vlad mentioned that the
fixedstatement can null-out references. Found that code inLocalRewriter_FixedStatement.csand factored it out into aNullRefhelper.This is emitted using the same IL as
ref T Unsafe.NullRef<T>(), namelyldc.i4.0followed byconv.u.No spec update required, as I think the desired behavior is already covered by auto-default-structs.md:
Fixes #63018
Relates to test plan #59194