Skip to content

allow us to build windows tfms on unix#63059

Merged
jmarolf merged 2 commits intodotnet:mainfrom
jmarolf:infrastructure/allow-roslyn.sln-to-be-built-on-unix
Jul 29, 2022
Merged

allow us to build windows tfms on unix#63059
jmarolf merged 2 commits intodotnet:mainfrom
jmarolf:infrastructure/allow-roslyn.sln-to-be-built-on-unix

Conversation

@jmarolf
Copy link
Copy Markdown
Contributor

@jmarolf jmarolf commented Jul 29, 2022

with this change you can just do

> dotnet build Roslyn.sln

on any OS and build will succeed (assuming you have the right SDK)

@jmarolf jmarolf requested a review from a team as a code owner July 29, 2022 17:49
@ghost ghost added the Area-Infrastructure label Jul 29, 2022
Copy link
Copy Markdown
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome.

@jmarolf jmarolf enabled auto-merge (squash) July 29, 2022 18:46
@jmarolf jmarolf merged commit 0cfdc30 into dotnet:main Jul 29, 2022
@ghost ghost added this to the Next milestone Jul 29, 2022
@davidwengier
Copy link
Copy Markdown
Member

Thank you @jmarolf

Follow up question: I'm probably gonna forget that dotnet build works, and run build.cmd at least once. Should it be changed to build Roslyn.sln instead of Compilers.sln on unix?

@jmarolf
Copy link
Copy Markdown
Contributor Author

jmarolf commented Aug 11, 2022

Thank you @jmarolf

Follow up question: I'm probably gonna forget that dotnet build works, and run build.cmd at least once. Should it be changed to build Roslyn.sln instead of Compilers.sln on unix?

I am making a change here: ac5883d to allow you to do this

> ./build.sh --solution Roslyn.sln

We can discuss with the compiler team what the default should be. @davidwengier I assume your preference would be to have a single ./build.sh and ./test.sh script that ran everything?

@davidwengier
Copy link
Copy Markdown
Member

Yeah, I would expect build.cmd and build.sh to do the same thing, basically. I often run it as a sanity check before pushing, particularly with -a, and have been bitten before by the fact that depending on which machine i'm on, it builds a different solution (and hence sometimes just doesn't compile the code I'm looking at)

@dibarbet dibarbet modified the milestones: Next, 17.4 P2 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants