You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow up question: I'm probably gonna forget that dotnet build works, and run build.cmd at least once. Should it be changed to build Roslyn.sln instead of Compilers.sln on unix?
Follow up question: I'm probably gonna forget that dotnet build works, and run build.cmd at least once. Should it be changed to build Roslyn.sln instead of Compilers.sln on unix?
I am making a change here: ac5883d to allow you to do this
> ./build.sh --solution Roslyn.sln
We can discuss with the compiler team what the default should be. @davidwengier I assume your preference would be to have a single ./build.sh and ./test.sh script that ran everything?
Yeah, I would expect build.cmd and build.sh to do the same thing, basically. I often run it as a sanity check before pushing, particularly with -a, and have been bitten before by the fact that depending on which machine i'm on, it builds a different solution (and hence sometimes just doesn't compile the code I'm looking at)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with this change you can just do
> dotnet build Roslyn.slnon any OS and build will succeed (assuming you have the right SDK)