Move to a simpler form of checksum->solution caching in the remote workspace layer. (2)#63028
Merged
CyrusNajmabadi merged 65 commits intodotnet:mainfrom Jul 29, 2022
Merged
Conversation
CyrusNajmabadi
commented
Jul 28, 2022
src/Workspaces/Remote/ServiceHub/Host/RemoteWorkspace_SolutionCaching.cs
Outdated
Show resolved
Hide resolved
dibarbet
reviewed
Jul 28, 2022
Member
dibarbet
left a comment
There was a problem hiding this comment.
I think it mostly looks fine? 2 comments that you can tell me if they are reasonable or not.
src/Workspaces/Remote/ServiceHub/Host/RemoteWorkspace.InFlightSolution.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The general idea here is that all 'in flight request' counting and all state management related to our cache is done in entirely one operation that updates everything atomically.
the old model was also confusing in that a single checksum could map to potentially two solutions (one connected to the workspace and one not), and it was unclear which you would get back. Now there's a single type that owns thsi concept and ensures a single mapping always for a checksum in the cache.