Deregister workspaces from LSP when they are disposed of#63025
Merged
dibarbet merged 3 commits intodotnet:mainfrom Jul 29, 2022
Merged
Deregister workspaces from LSP when they are disposed of#63025dibarbet merged 3 commits intodotnet:mainfrom
dibarbet merged 3 commits intodotnet:mainfrom
Conversation
Therzok
approved these changes
Jul 28, 2022
JoeRobich
approved these changes
Jul 28, 2022
marshall-lerner
approved these changes
Jul 28, 2022
Therzok
approved these changes
Jul 28, 2022
davidwengier
approved these changes
Jul 28, 2022
src/Features/LanguageServer/Protocol/Workspaces/LspWorkspaceRegistrationService.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike vswindows, vsmac disposes of their host workspace when a solution is closed. This can cause a leak because the LSP workspace registration service was holding onto all registered workspaces even if they are disposed.