Rename parameter for clarity#63023
Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom Jul 29, 2022
Merged
Conversation
CyrusNajmabadi
commented
Jul 28, 2022
|
|
||
| var solutionChecksum = await solution.State.GetChecksumAsync(CancellationToken.None); | ||
| var synched = await remoteWorkspace.GetTestAccessor().GetSolutionAsync(assetProvider, solutionChecksum, fromPrimaryBranch: false, workspaceVersion: -1, CancellationToken.None); | ||
| var synched = await remoteWorkspace.GetTestAccessor().GetSolutionAsync(assetProvider, solutionChecksum, updatePrimaryBranch: false, workspaceVersion: -1, CancellationToken.None); |
Contributor
Author
There was a problem hiding this comment.
renamed this to be clear what this flag is intending to convey. the flag it an actual request to the RemoteWorkspace to not only get the solution but update it's primary solution to point at that.
dibarbet
approved these changes
Jul 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled out of #62872 to make that PR smaller.