Check the right matches in lambdas#63006
Merged
davidwengier merged 4 commits intodotnet:mainfrom Aug 2, 2022
Merged
Conversation
davidwengier
commented
Jul 28, 2022
src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs
Outdated
Show resolved
Hide resolved
Member
Author
tmat
reviewed
Jul 28, 2022
| public void LocalFunction_EditAroundTry_WithActiveStatement() | ||
| { | ||
| var src1 = | ||
| """ |
Member
Member
Author
There was a problem hiding this comment.
In this case, with no quotes in the string, the only thing the raw string is providing is that the test input doesn't have to be based on column 0, so flows better in the IDE. The extra indentation is not present in the actual test input of course.
Member
There was a problem hiding this comment.
Of course, though "flows better" is subjective here. I feel like I need to subtract the whitespace in my head when reading the embedded source code.
Member
Author
There was a problem hiding this comment.
Yeah, thats a good point. I'm very used to the vertical line in VS that takes away that pain.
Member
There was a problem hiding this comment.
Yup, it's better in VS but sadly github/CodeFlow do not have it :(
tmat
reviewed
Jul 28, 2022
tmat
reviewed
Jul 28, 2022
src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Member
Author
|
ping @tmat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61415