Skip to content

Comment out unused analyzer diagnostic id#62971

Merged
mavasani merged 2 commits intodotnet:mainfrom
Youssef1313:patch-29
Jul 27, 2022
Merged

Comment out unused analyzer diagnostic id#62971
mavasani merged 2 commits intodotnet:mainfrom
Youssef1313:patch-29

Conversation

@Youssef1313
Copy link
Copy Markdown
Member

@Youssef1313 Youssef1313 commented Jul 27, 2022

No description provided.

@Youssef1313 Youssef1313 requested a review from a team as a code owner July 27, 2022 10:07
@ghost ghost added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Jul 27, 2022
@mavasani
Copy link
Copy Markdown
Contributor

mavasani commented Jul 27, 2022

@Youssef1313 There are test failures.

@Youssef1313
Copy link
Copy Markdown
Member Author

Youssef1313 commented Jul 27, 2022

Thanks @mavasani. I fixed the failure.

@mavasani mavasani merged commit 6f85d60 into dotnet:main Jul 27, 2022
@ghost ghost added this to the Next milestone Jul 27, 2022
@Youssef1313 Youssef1313 deleted the patch-29 branch July 27, 2022 15:05
@allisonchou allisonchou mentioned this pull request Aug 3, 2022
Closed
@dibarbet dibarbet modified the milestones: Next, 17.4 P2 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mavasani mavasani mavasani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Youssef1313 @mavasani @dibarbet