Move BraceMatching data service down to Features layer.#62965
Merged
CyrusNajmabadi merged 3 commits intodotnet:mainfrom Jul 27, 2022
Merged
Move BraceMatching data service down to Features layer.#62965CyrusNajmabadi merged 3 commits intodotnet:mainfrom
CyrusNajmabadi merged 3 commits intodotnet:mainfrom
Conversation
ryzngard
approved these changes
Jul 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found as part of Asp.net route highlighting work. This puts it at the same layer as DocumentHighlighting. The data portion should be at Features, while anything UI related is in EditorFeatures. This will also make it possible for LSP to use this if LSP ever moves off of textmate for doing brace matching.