Skip to content

Move option code over to using snapshots#62959

Merged
CyrusNajmabadi merged 9 commits intodotnet:mainfrom
CyrusNajmabadi:banAPI5
Jul 27, 2022
Merged

Move option code over to using snapshots#62959
CyrusNajmabadi merged 9 commits intodotnet:mainfrom
CyrusNajmabadi:banAPI5

Conversation

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

No description provided.

@ghost ghost added the Area-IDE label Jul 26, 2022
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review July 27, 2022 04:06
@CyrusNajmabadi CyrusNajmabadi requested review from a team, 333fred and JoeRobich as code owners July 27, 2022 04:06
@CyrusNajmabadi CyrusNajmabadi requested a review from a team July 27, 2022 04:06
Copy link
Copy Markdown
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great; I'm not sure if there's a follow-up though for the DelegatingCodeActionOptionsProvider type that had one change that looked a bit suspicious.

@CyrusNajmabadi CyrusNajmabadi merged commit 5946cd9 into dotnet:main Jul 27, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the banAPI5 branch July 27, 2022 19:32
@ghost ghost added this to the Next milestone Jul 27, 2022
@dibarbet dibarbet modified the milestones: Next, 17.4 P2 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants