Skip to content

Fix SyntaxGenerator not working correctly with 'required'#62945

Merged
RikkiGibson merged 1 commit intodotnet:mainfrom
Youssef1313:fix-required-syntax-generator
Aug 8, 2022
Merged

Fix SyntaxGenerator not working correctly with 'required'#62945
RikkiGibson merged 1 commit intodotnet:mainfrom
Youssef1313:fix-required-syntax-generator

Conversation

@Youssef1313
Copy link
Member

Fixes #62371

@Youssef1313 Youssef1313 marked this pull request as ready for review July 26, 2022 17:36
@Youssef1313 Youssef1313 requested a review from a team as a code owner July 26, 2022 17:36
@ghost ghost added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Jul 26, 2022
Copy link
Contributor

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Youssef1313
Copy link
Member Author

@CyrusNajmabadi @RikkiGibson Anything left to merge this? Thanks!

@RikkiGibson RikkiGibson self-assigned this Aug 8, 2022
@RikkiGibson RikkiGibson merged commit 2f62c90 into dotnet:main Aug 8, 2022
@RikkiGibson
Copy link
Member

Thanks @Youssef1313!

@ghost ghost added this to the Next milestone Aug 8, 2022
@Youssef1313 Youssef1313 deleted the fix-required-syntax-generator branch August 8, 2022 19:37
@dibarbet dibarbet modified the milestones: Next, 17.4 P2 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File and required modifiers are missing from CSharpAccessibilityFacts.GetAccessibilityAndModifiers

4 participants