Skip to content

Merge release/dev17.3 to main#62927

Merged
JoeRobich merged 3 commits intomainfrom
merges/release/dev17.3-to-main
Jul 28, 2022
Merged

Merge release/dev17.3 to main#62927
JoeRobich merged 3 commits intomainfrom
merges/release/dev17.3-to-main

Conversation

@dotnet-bot
Copy link
Copy Markdown
Collaborator

This is an automatically generated pull request from release/dev17.3 into main.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/release/dev17.3-to-main
git reset --hard upstream/main
git merge upstream/release/dev17.3
# Fix merge conflicts
git commit
git push upstream merges/release/dev17.3-to-main --force

…hanged (#62849)

* HasChangesAsync should return false if the document content did not changed

* Comment

* Test source generated docs

* Fix rebase

* Include PopulateChangedAndAddedDocumentsAsync in test
@dotnet-bot dotnet-bot requested a review from a team as a code owner July 26, 2022 00:03
@dotnet-bot dotnet-bot force-pushed the merges/release/dev17.3-to-main branch from c919ee8 to a8c241a Compare July 26, 2022 00:03
@dotnet-bot dotnet-bot added Area-Infrastructure auto-merge Merge Conflicts There are merge conflicts with the base branch. labels Jul 26, 2022
@dotnet-bot
Copy link
Copy Markdown
Collaborator Author

⚠ This PR has merge conflicts. @allisonchou

@dotnet-bot dotnet-bot enabled auto-merge July 26, 2022 00:03
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@allisonchou
Copy link
Copy Markdown
Contributor

@tmat could you take a look at the conflicts?

@JoeRobich
Copy link
Copy Markdown
Member

I took a stab at the conflicts.

@JoeRobich JoeRobich removed the Merge Conflicts There are merge conflicts with the base branch. label Jul 27, 2022
@JoeRobich JoeRobich disabled auto-merge July 28, 2022 20:46
@JoeRobich JoeRobich merged commit 11a33f0 into main Jul 28, 2022
@ghost ghost added this to the Next milestone Jul 28, 2022
@dibarbet dibarbet modified the milestones: Next, 17.4 P2 Sep 1, 2022
@JoeRobich JoeRobich deleted the merges/release/dev17.3-to-main branch May 7, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants