Issue delete and insert edits when changing parameters#62897
Merged
davidwengier merged 7 commits intodotnet:mainfrom Aug 2, 2022
Merged
Issue delete and insert edits when changing parameters#62897davidwengier merged 7 commits intodotnet:mainfrom
davidwengier merged 7 commits intodotnet:mainfrom
Conversation
Member
Author
|
@tmat PTAL |
tmat
reviewed
Jul 26, 2022
src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs
Show resolved
Hide resolved
tmat
reviewed
Jul 26, 2022
src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs
Show resolved
Hide resolved
tmat
reviewed
Jul 26, 2022
|
|
||
| // Some sanity checks | ||
| if (otherModel is null || | ||
| containingSymbol.DeclaringSyntaxReferences.Length != 1) |
Member
Member
Author
There was a problem hiding this comment.
This part wasn't a problem with partial methods, so maybe I missed something, but I added a test, and another check to make the test pass :)
tmat
reviewed
Jul 26, 2022
src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs
Outdated
Show resolved
Hide resolved
tmat
reviewed
Jul 26, 2022
| } | ||
|
|
||
| // Now we can work out which is the old and which is the new, depending on which map we found | ||
| // the match in |
Member
There was a problem hiding this comment.
Doesn't the caller already know this?
Member
Author
There was a problem hiding this comment.
The caller knows which map the lookup will work in, yes.
tmat
reviewed
Jul 26, 2022
src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs
Outdated
Show resolved
Hide resolved
Member
|
Reviewed 5 commits. Looks good, just a few minor things. |
Member
Author
|
ping @tmat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #59264
I was going to do return type changes with this too, but need to either change SymbolKey, or changes to the SemanticEditInfoComparer: https://github.com/dotnet/roslyn/blob/main/src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs#L3416