Produce binding errors for incomplete members#62874
Draft
Youssef1313 wants to merge 52 commits intodotnet:mainfrom
Draft
Produce binding errors for incomplete members#62874Youssef1313 wants to merge 52 commits intodotnet:mainfrom
Youssef1313 wants to merge 52 commits intodotnet:mainfrom
Conversation
Youssef1313
commented
Jul 22, 2022
src/Compilers/CSharp/Portable/Symbols/Source/SourceIncompleteMemberSymbol.cs
Outdated
Show resolved
Hide resolved
0bb0314 to
3686e6b
Compare
Youssef1313
commented
Jul 23, 2022
src/Compilers/CSharp/Portable/Symbols/Source/SourceMemberContainerSymbol.cs
Outdated
Show resolved
Hide resolved
Youssef1313
commented
Jul 23, 2022
src/Compilers/CSharp/Portable/Symbols/Source/SourceMemberContainerSymbol.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
|
Member
|
I think we need to wait until @AlekseyTs is back from vacation on this one before proceeding. |
10 tasks
IDE change is for `TestAfterRootAttribute` completion tests
Member
Author
|
@AlekseyTs Could you take a look? (I haven't done work for VB side yet) |
Youssef1313
commented
Jan 26, 2023
Comment on lines
+1455
to
1459
| #pragma warning disable CS0618 // Type or member is obsolete | ||
| case SyntaxKind.IncompleteMember: | ||
| #pragma warning restore CS0618 // Type or member is obsolete | ||
| // Incomplete members don't declare any symbols. | ||
| return null; |
Member
Author
There was a problem hiding this comment.
The only way to reach this is crafting a tree using the obsolete SyntaxFactory.IncompleteMember API. So I kept this as return null.
I think we will want to have a test whose behavior changes depending on the existence of this code path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7536
FYI @CyrusNajmabadi