Skip to content

Use OmniSharp LineFormatting fallback options in more places.#62690

Merged
JoeRobich merged 1 commit intodotnet:mainfrom
JoeRobich:pass-fallback-options
Jul 15, 2022
Merged

Use OmniSharp LineFormatting fallback options in more places.#62690
JoeRobich merged 1 commit intodotnet:mainfrom
JoeRobich:pass-fallback-options

Conversation

@JoeRobich
Copy link
Copy Markdown
Member

@JoeRobich JoeRobich commented Jul 15, 2022

OmniSharp sets these "global" formatting options on the Solution.OptionSet. However, when fallback options are not specified, we expect to find the values from AnalyzerConfigOptions. These changes specifically pass in the "global" values of these options as a fallback.

@JoeRobich JoeRobich requested a review from 333fred as a code owner July 15, 2022 21:29
@ghost ghost added the Area-Infrastructure label Jul 15, 2022
@JoeRobich JoeRobich enabled auto-merge July 15, 2022 22:15
@JoeRobich JoeRobich merged commit 34c4289 into dotnet:main Jul 15, 2022
@ghost ghost added this to the Next milestone Jul 15, 2022
@allisonchou allisonchou modified the milestones: Next, 17.4 P1 Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants