Skip to content

Use the correct option for splitting comments#62680

Merged
mavasani merged 2 commits intodotnet:mainfrom
Youssef1313:patch-17
Aug 11, 2022
Merged

Use the correct option for splitting comments#62680
mavasani merged 2 commits intodotnet:mainfrom
Youssef1313:patch-17

Conversation

@Youssef1313
Copy link
Copy Markdown
Member

@Youssef1313 Youssef1313 commented Jul 15, 2022

Part of #62362, pending test.

@Youssef1313 Youssef1313 requested a review from a team as a code owner July 15, 2022 18:03
@ghost ghost added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Jul 15, 2022
@mavasani
Copy link
Copy Markdown
Contributor

Do you plan to add a test for it once your other PR that adds tests for these controls gets merged?

@Youssef1313
Copy link
Copy Markdown
Member Author

Yes sure, let's keep the issue open to track adding the test.

@sharwell sharwell changed the title Use the corrent option for splitting comments Use the correct option for splitting comments Jul 15, 2022
@Youssef1313
Copy link
Copy Markdown
Member Author

@mavasani Is this ready to merge?

@Youssef1313
Copy link
Copy Markdown
Member Author

Also reported in #63309.

Ping @mavasani @tmat

@mavasani mavasani merged commit afef833 into dotnet:main Aug 11, 2022
@ghost ghost added this to the Next milestone Aug 11, 2022
@Youssef1313 Youssef1313 deleted the patch-17 branch August 11, 2022 05:22
@dibarbet dibarbet modified the milestones: Next, 17.4 P2 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants