Skip to content

Merge release/dev17.3 to release/dev17.3-vs-deps#62637

Merged
JoeRobich merged 2 commits intorelease/dev17.3-vs-depsfrom
merges/release/dev17.3-to-release/dev17.3-vs-deps
Jul 15, 2022
Merged

Merge release/dev17.3 to release/dev17.3-vs-deps#62637
JoeRobich merged 2 commits intorelease/dev17.3-vs-depsfrom
merges/release/dev17.3-to-release/dev17.3-vs-deps

Conversation

@dotnet-bot
Copy link
Copy Markdown
Collaborator

This is an automatically generated pull request from release/dev17.3 into release/dev17.3-vs-deps.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/release/dev17.3-to-release/dev17.3-vs-deps
git reset --hard upstream/release/dev17.3-vs-deps
git merge upstream/release/dev17.3
# Fix merge conflicts
git commit
git push upstream merges/release/dev17.3-to-release/dev17.3-vs-deps --force

Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

The actual "run tests" portion of our integration tests specify a
timeout of 110 minutes; however, it can take 20 minutes of restore
and build before we actually get to that portion of the job. I'm
investigating a test hang where it seems like the 110 minute timeout is
hit but just moments later Azure starts to kill the entire job.
@dotnet-bot dotnet-bot requested a review from a team as a code owner July 15, 2022 21:03
@JoeRobich JoeRobich disabled auto-merge July 15, 2022 23:58
@JoeRobich JoeRobich merged commit a6e963e into release/dev17.3-vs-deps Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants