Skip to content

Snap main-vs-deps to release/dev17.3-vs-deps#62194

Merged
RikkiGibson merged 1126 commits intorelease/dev17.3-vs-depsfrom
merges/main-vs-deps-to-release/dev17.3-vs-deps
Jun 29, 2022
Merged

Snap main-vs-deps to release/dev17.3-vs-deps#62194
RikkiGibson merged 1126 commits intorelease/dev17.3-vs-depsfrom
merges/main-vs-deps-to-release/dev17.3-vs-deps

Conversation

@RikkiGibson
Copy link
Copy Markdown
Member

No description provided.

genlu and others added 30 commits June 15, 2022 16:52
Actually return filtered items for default implementation
NRT enable symbolfinder/find-refs code.
…rting NFE (#61792)

* Convert connection lost exceptions to cancellations to avoid overreporting NFE

* Typo and comment

* Feedback

* Refactoring
* Avoid accessing Document from formatter services

* Push async higher

* Split file

* Rename
Recently we enabled FixAll functionality for a bunch of code refactorings. We have been seen intermittent failures in CI for the FixAll tests added for this. I was able to reproduce the failures locally quite consistently by running the test under a loop with thousands of iterations. Upon investigation it was found that when the test fails, the [underlying CWT](https://github.com/dotnet/roslyn/blob/73de4e98d3020c72a2eef479d267357c15332d80/src/Compilers/Core/Portable/Syntax/SyntaxNodeExtensions_Tracking.cs#L18) used by TrackNodes functionality seems to have cleared the entries for nodes requested to be tracked by this FixAll operations. Adding a ToArray invocation to the tracked nodes to realize the nodes into an array seems to ensure that this doesn't happen and the test passes consistently after this change.

Ideally, we would have expected the `SyntaxEditor.OriginalRoot` to keep all the nodes in the original tree alive, but that doesn't seem to be the case. Long term, we may want to consider adding a new TrackNodes API that does the tracking using dictionaries instead of CWTs and returns a disposable tracker object, such that the caller explicitly controls the lifetime of the tracking.
* Add support for additional file diagnostics in workspace pull

* fix formatting

* Fix more formatting
Use 'Clear' to empty a CWT when on .net core
* Remove serialization

* Workspace tests refactoring, add public option tests

* Remove usage of Workspace.SetOptions from tests

* Fix

* Remove Workspace.SetOptions

* Remove serializable options from SerializableOptionSet

* Cleanup

* Merge WorkspaceOptionSet into SerializableOptionSet

* Rename

* IOptionService

* Remove unused obsolete Razor EA API

* Remove

* Formatting

* Feedback
Support embedded languages on named attribute arguments
Fix logic issue in find-refs that could fail to find related symbols in inheritance
@RikkiGibson RikkiGibson requested review from a team, 333fred and JoeRobich as code owners June 28, 2022 20:28
@RikkiGibson RikkiGibson requested review from a team and removed request for a team, 333fred and JoeRobich June 28, 2022 20:28
@RikkiGibson RikkiGibson merged commit fb9334a into release/dev17.3-vs-deps Jun 29, 2022
@RikkiGibson RikkiGibson deleted the merges/main-vs-deps-to-release/dev17.3-vs-deps branch June 29, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.