Merged
Conversation
Fix typo pointed out by @RikkiGibson in dotnet#62172 (comment).
cston
approved these changes
Jun 28, 2022
Member
Author
|
@dotnet/roslyn-compiler for a couple of reviews of this small concurrency fix. |
RikkiGibson
reviewed
Jun 28, 2022
| if (_lazyRequiredMembers == RequiredMembersErrorSentinel) | ||
| if (lazyRequiredMembers == RequiredMembersErrorSentinel) | ||
| { | ||
| if (lazyRequiredMembers.IsDefault) |
Member
There was a problem hiding this comment.
I didn't understand under what conditions we can:
- have 'lazyRequiredMembers' be equal to the error sentinel (which is non-empty, looks like?)
- and then have it turn out to be default.
Could you please clarify?
Member
Author
There was a problem hiding this comment.
I believe this was incorrect logic left over from when I was using a sentinel in a different manner. I've corrected the logic to immediately return false when the sentinel is encountered.
cston
approved these changes
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix typo pointed out by @RikkiGibson in #62172 (comment).