Separate out connection failures#62136
Merged
jaredpar merged 2 commits intodotnet:mainfrom Jun 27, 2022
Merged
Conversation
This changes the compiler to have a specific failure when it cannot connect to the server. This lets us treat it separately from cases where the server connected succeeded but the server rejected the request. The reason for this change is cannot connect failures are not necessarily an indicator of a code issue. A fully functional build can hit connection issues for a variety of reasons. For example if the server is too busy and can't respond to a connection event in time. Having a separate response means we can handle the failures differently in bootstrap builds. The bootstrap build will not fail now until it sees more than three of these. That should reduce the false positive rate we see in our infra.
Member
Author
|
@dotnet/roslyn-compiler PTAL. This is a small change that should reduce the number of times our bootstrap build fails due to connection issues in the server. |
cston
approved these changes
Jun 24, 2022
333fred
approved these changes
Jun 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the compiler to have a specific failure when it cannot
connect to the server. This lets us treat it separately from cases where
the server connected succeeded but the server rejected the request.
The reason for this change is cannot connect failures are not
necessarily an indicator of a code issue. A fully functional build can
hit connection issues for a variety of reasons. For example if the
server is too busy and can't respond to a connection event in time.
Having a separate response means we can handle the failures differently
in bootstrap builds. The bootstrap build will not fail now until it sees
more than three of these. That should reduce the false positive rate we
see in our infra.