Skip to content

Move to a shared stopwatch in the incremental generator#62134

Merged
jcouv merged 1 commit intodotnet:mainfrom
CyrusNajmabadi:stopwatch
Jun 27, 2022
Merged

Move to a shared stopwatch in the incremental generator#62134
jcouv merged 1 commit intodotnet:mainfrom
CyrusNajmabadi:stopwatch

Conversation

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

Shaves off around 700 MB of unnecessary allocations:

image

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor Author

@dotnet/roslyn-compiler for a very tiny change, but big memory win.

Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv self-assigned this Jun 26, 2022
@CyrusNajmabadi CyrusNajmabadi enabled auto-merge June 26, 2022 02:01
@jcouv jcouv disabled auto-merge June 27, 2022 16:40
@jcouv jcouv merged commit ac758ed into dotnet:main Jun 27, 2022
@ghost ghost added this to the Next milestone Jun 27, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the stopwatch branch June 27, 2022 17:25
@RikkiGibson RikkiGibson modified the milestones: Next, 17.3 P3 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants