Allow delegate*<...>? to be scanned/parsed and add diagnostic to binder#62104
Merged
Allow delegate*<...>? to be scanned/parsed and add diagnostic to binder#62104
delegate*<...>? to be scanned/parsed and add diagnostic to binder#62104Conversation
|
|
333fred
reviewed
Jun 23, 2022
src/Compilers/CSharp/Test/Semantic/Semantics/FunctionPointerTests.cs
Outdated
Show resolved
Hide resolved
src/Compilers/CSharp/Test/Semantic/Semantics/FunctionPointerTests.cs
Outdated
Show resolved
Hide resolved
jcouv
approved these changes
Jun 26, 2022
Member
jcouv
left a comment
There was a problem hiding this comment.
LGTM Thanks (iteration 2). The main branch is closed at the moment, but when it re-opens, please use the Squash option when merging the PR.
Member
|
To avoid this getting out of date, I'm going to go ahead and merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #53973 . Allows
ScanType()andParseType()to recognizedelegate*<...>?syntax. Note that there is already an existing diagnostic which is triggered by the binder in this case becausedelegate*is already disallowed as a type parameter. However, there is now a new diagnostic,ErrFunctionPointersCannotBeNullableto make it extra clear that a nullable function pointer is not allowed.