Standardize references to the UTF-8 term in code and comments/documentation#62074
Merged
AlekseyTs merged 6 commits intodotnet:mainfrom Jun 27, 2022
Merged
Standardize references to the UTF-8 term in code and comments/documentation#62074AlekseyTs merged 6 commits intodotnet:mainfrom
AlekseyTs merged 6 commits intodotnet:mainfrom
Conversation
From a framework naming perspective, “Utf8” is preferred, because it’s a 3 letter abbreviation (for Unicode Transformation Format), and 3+ letter abbreviations should be PascalCased, like Html and Uri. From a documentation/conceptual perspective, the preferred spelling of the Unicode Consortium seems to be “UTF-8” (all caps, with a hyphen). Closes dotnet#61847.
Closes dotnet#61846.
jcouv
approved these changes
Jun 22, 2022
Member
jcouv
left a comment
There was a problem hiding this comment.
LGTM Thanks, both compiler and IDE changes looked at (iteration 5)
Contributor
Author
|
@dotnet/roslyn-compiler For the second review. |
Contributor
Author
|
@davidwengier For review of IDE side |
Contributor
Author
|
@cston, @RikkiGibson, @dotnet/roslyn-compiler For the second review. |
Contributor
Author
|
@davidwengier Please take a look at IDE side of changes. |
Contributor
Author
|
@davidwengier Sorry, missed your sign-off, please disregard previous message. |
cston
reviewed
Jun 23, 2022
| EncodingUTF8, | ||
| EncodingUTF8_BOM, | ||
| EncodingUtf8, | ||
| EncodingUtf8_BOM, |
Contributor
There was a problem hiding this comment.
It looks like these should be kept as-is, or "EncodingUTF32*" should be updated as well.
cston
approved these changes
Jun 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From a framework naming perspective, “Utf8” is preferred, because it’s a 3 letter abbreviation (for Unicode Transformation Format), and 3+ letter abbreviations should be PascalCased, like Html and Uri.
From a documentation/conceptual perspective, the preferred spelling of the Unicode Consortium seems to be “UTF-8” (all caps, with a hyphen).
Closes #61847.
Also fixes a typo and closes #61846.