Skip to content

Add NFW report to FindRefs to help track down an issue.#62058

Merged
CyrusNajmabadi merged 2 commits intodotnet:mainfrom
CyrusNajmabadi:findRefNfw
Jun 21, 2022
Merged

Add NFW report to FindRefs to help track down an issue.#62058
CyrusNajmabadi merged 2 commits intodotnet:mainfrom
CyrusNajmabadi:findRefNfw

Conversation

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner June 21, 2022 17:34
@ghost ghost added the Area-IDE label Jun 21, 2022

await _context.OnDefinitionFoundAsync(rehydrated, cancellationToken).ConfigureAwait(false);
}
catch (Exception ex) when (FatalError.ReportAndPropagateUnlessCanceled(ex, cancellationToken))
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you want to have a comment here saying what this is to investigate, but at the same time this is probably worth permanently keeping here for future bugs down the road?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is worth permanently keeping in.

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge June 21, 2022 18:09
@CyrusNajmabadi CyrusNajmabadi merged commit 74641d7 into dotnet:main Jun 21, 2022
@ghost ghost added this to the Next milestone Jun 21, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the findRefNfw branch June 21, 2022 20:46
@RikkiGibson RikkiGibson modified the milestones: Next, 17.3 P3 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants