Fix stack overflow in CSharpStringIndentationService#61978
Merged
sharwell merged 1 commit intodotnet:mainfrom Jun 20, 2022
Merged
Fix stack overflow in CSharpStringIndentationService#61978sharwell merged 1 commit intodotnet:mainfrom
sharwell merged 1 commit intodotnet:mainfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
genlu
reviewed
Jun 17, 2022
| // If necessary, push the current node so we can pick back up after processing the child | ||
| if (i < childList.Count - 1) | ||
| { | ||
| nodeStack.Push((node, i + 1)); |
Member
There was a problem hiding this comment.
Is it important to keep the traveral order as DFS here?
Contributor
Author
There was a problem hiding this comment.
It appears so. Otherwise, I'm not sure what order the result array will end up in.
genlu
approved these changes
Jun 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert a recursive-descent algorithm to iterating over a separate work stack.
Fixes AB#1542623