Add paranoia checks and more logging for a failure case#61898
Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom Jun 14, 2022
Merged
Add paranoia checks and more logging for a failure case#61898CyrusNajmabadi merged 1 commit intodotnet:mainfrom
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
Conversation
CyrusNajmabadi
commented
Jun 14, 2022
Comment on lines
+94
to
+98
| if (!method.Equals(method.ConstructedFrom)) | ||
| continue; | ||
|
|
||
| if (method.Arity == 0) | ||
| continue; |
Contributor
Author
There was a problem hiding this comment.
these two checks exactly match the condition checked for here:
just making sure we don't violate this ourselves.
ryzngard
approved these changes
Jun 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeing a failure in telemetry. Adding more info to track down what case it may be.