Skip to content

Disallow required members in scripts and submissions#61889

Merged
333fred merged 1 commit intodotnet:mainfrom
333fred:script-required-members
Jun 14, 2022
Merged

Disallow required members in scripts and submissions#61889
333fred merged 1 commit intodotnet:mainfrom
333fred:script-required-members

Conversation

@333fred
Copy link
Copy Markdown
Member

@333fred 333fred commented Jun 14, 2022

These types aren't created by users and can't be initialized with an object initializer, so required members are blocked. Fixes #61822.

These types aren't created by users and can't be initialized with an object initializer, so required members are blocked. Fixes dotnet#61822.
@333fred 333fred requested a review from a team as a code owner June 14, 2022 19:36
@ghost ghost added the Area-Compilers label Jun 14, 2022
@333fred
Copy link
Copy Markdown
Member Author

333fred commented Jun 14, 2022

@dotnet/roslyn-compiler @jcouv @RikkiGibson for reviews please.

@333fred 333fred added the Feature - Required Members Required properties and fields label Jun 14, 2022
@RikkiGibson RikkiGibson self-assigned this Jun 14, 2022
Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@333fred
Copy link
Copy Markdown
Member Author

333fred commented Jun 14, 2022

@dotnet/roslyn-compiler @RikkiGibson for a second review.

@333fred 333fred merged commit 5fc678f into dotnet:main Jun 14, 2022
@333fred 333fred deleted the script-required-members branch June 14, 2022 23:25
@ghost ghost added this to the Next milestone Jun 14, 2022
@RikkiGibson RikkiGibson modified the milestones: Next, 17.3 P3 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Feature - Required Members Required properties and fields

Projects

None yet

Development

Successfully merging this pull request may close these issues.

required usage in script compilations

4 participants