Skip to content

Avoid double typechecks in simple code checks#61730

Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
CyrusNajmabadi:typeCheckAndCast
Jun 7, 2022
Merged

Avoid double typechecks in simple code checks#61730
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
CyrusNajmabadi:typeCheckAndCast

Conversation

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

No description provided.

@CyrusNajmabadi CyrusNajmabadi requested review from a team as code owners June 6, 2022 20:33
@ghost ghost added the Area-Compilers label Jun 6, 2022
@CyrusNajmabadi
Copy link
Copy Markdown
Contributor Author

@jcouv @cston for two lines of compiler change :)

Copy link
Copy Markdown
Contributor

@cston cston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiler changes LGTM.

Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv jcouv self-assigned this Jun 6, 2022
@jcouv
Copy link
Copy Markdown
Member

jcouv commented Jun 7, 2022

@CyrusNajmabadi PR can be merged/squashed. Thanks

@CyrusNajmabadi CyrusNajmabadi merged commit af17744 into dotnet:main Jun 7, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the typeCheckAndCast branch June 7, 2022 06:16
@ghost ghost added this to the Next milestone Jun 7, 2022
@CyrusNajmabadi
Copy link
Copy Markdown
Contributor Author

Done. Thanks!

@RikkiGibson RikkiGibson modified the milestones: Next, 17.3 P3 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants