Nullable annotate the lexer and a few related files#61688
Merged
RikkiGibson merged 5 commits intodotnet:mainfrom Jun 3, 2022
Merged
Nullable annotate the lexer and a few related files#61688RikkiGibson merged 5 commits intodotnet:mainfrom
RikkiGibson merged 5 commits intodotnet:mainfrom
Conversation
Neme12
commented
Jun 3, 2022
RikkiGibson
approved these changes
Jun 3, 2022
| TextWindow.Reset(beforeConsumed); | ||
|
|
||
| if (this.ScanIdentifier(ref info) && info.Text.Length > 0) | ||
| if (this.ScanIdentifier(ref info) && info.Text!.Length > 0) |
Member
There was a problem hiding this comment.
It looks like there are several situations in this file where dotnet/csharplang#4563 would be useful.
Member
|
Thanks for the contribution @Neme12! |
Contributor
Author
|
Thanks 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally did this when working on #61662 (going by the rule for incremental adoption of nullable to annotate the files that you touch), but was told to put it in a separate PR.