Skip to content

Fixed nullability of enums in switches#61683

Merged
CyrusNajmabadi merged 4 commits intodotnet:mainfrom
DoctorKrolic:no-nullable-enums-in-switch
Jun 3, 2022
Merged

Fixed nullability of enums in switches#61683
CyrusNajmabadi merged 4 commits intodotnet:mainfrom
DoctorKrolic:no-nullable-enums-in-switch

Conversation

@DoctorKrolic
Copy link
Copy Markdown
Contributor

@DoctorKrolic DoctorKrolic commented Jun 3, 2022

Fixes: #61594

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner June 3, 2022 12:30
@ghost ghost added Community The pull request was submitted by a contributor who is not a Microsoft employee. Area-IDE labels Jun 3, 2022
@DoctorKrolic
Copy link
Copy Markdown
Contributor Author

DoctorKrolic commented Jun 3, 2022

@CyrusNajmabadi Done. That was a bit harder than I thought...

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge June 3, 2022 22:10
@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

CyrusNajmabadi commented Jun 3, 2022

Thanks!

@CyrusNajmabadi CyrusNajmabadi merged commit 945f9df into dotnet:main Jun 3, 2022
@ghost ghost added this to the Next milestone Jun 3, 2022
@DoctorKrolic DoctorKrolic deleted the no-nullable-enums-in-switch branch June 4, 2022 07:25
@RikkiGibson RikkiGibson modified the milestones: Next, 17.3 P3 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Milestone

17.3 P3

Development

Successfully merging this pull request may close these issues.

IDE0072 Add missing cases not well implemented when nullable

4 participants

@DoctorKrolic @CyrusNajmabadi @Youssef1313 @RikkiGibson