Allow SyntaxOffset in EnC state machine map to be negative#61667
Merged
tmat merged 2 commits intodotnet:release/dev17.3from Jun 3, 2022
Merged
Allow SyntaxOffset in EnC state machine map to be negative#61667tmat merged 2 commits intodotnet:release/dev17.3from
tmat merged 2 commits intodotnet:release/dev17.3from
Conversation
Member
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
cston
approved these changes
Jun 2, 2022
Member
nit: consider adding description from OP as comment Refers to: src/Compilers/Core/Portable/Emit/EditAndContinueMethodDebugInformation.cs:307 in 6cbf42f. [](commit_id = 6cbf42f, deletion_comment = False) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the same pattern for encoding the blob as other EnC debug infos with syntax offsets: Negative syntax offsets are rare - only when the syntax node is in an initializer of a field or property. To optimize for size calculates the base offset and adds it to all syntax offsets. In common cases (no negative offsets) this base offset is gonna be 0. Otherwise it's gonna be the lowest negative offset.
TODO: