Fixed incorrect discard suggestion in var pattern#61657
Merged
davidwengier merged 3 commits intodotnet:mainfrom Jun 6, 2022
DoctorKrolic:discard-in-var-pattern
Merged
Fixed incorrect discard suggestion in var pattern#61657davidwengier merged 3 commits intodotnet:mainfrom DoctorKrolic:discard-in-var-pattern
davidwengier merged 3 commits intodotnet:mainfrom
DoctorKrolic:discard-in-var-pattern
Conversation
DoctorKrolic
commented
Jun 2, 2022
src/Analyzers/CSharp/Tests/RemoveUnusedParametersAndValues/RemoveUnusedValueAssignmentTests.cs
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Jun 2, 2022
...ic/CodeFixes/RemoveUnusedParametersAndValues/VisualBasicRemoveUnusedValuesCodeFixProvider.vb
Outdated
Show resolved
Hide resolved
sharwell
reviewed
Jun 2, 2022
.../CSharp/CodeFixes/RemoveUnusedParametersAndValues/CSharpRemoveUnusedValuesCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
sharwell
suggested changes
Jun 2, 2022
Contributor
sharwell
left a comment
There was a problem hiding this comment.
Requesting two changes:
- Fix the trivia when
var _is used - Preserve the use of
_in cases wherevar _is unnecessary
davidwengier
reviewed
Jun 3, 2022
.../CSharp/CodeFixes/RemoveUnusedParametersAndValues/CSharpRemoveUnusedValuesCodeFixProvider.cs
Outdated
Show resolved
Hide resolved
sharwell
approved these changes
Jun 3, 2022
davidwengier
approved these changes
Jun 6, 2022
Member
|
Thanks |
Contributor
|
The CI build after merge is showing an error like this:
/cc @dibarbet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #45768