Skip to content

Remove obsolete external access API now that intellicode has switched over#61635

Merged
dibarbet merged 1 commit intodotnet:release/dev17.3from
dibarbet:remove_obsolete_api
Jun 1, 2022
Merged

Remove obsolete external access API now that intellicode has switched over#61635
dibarbet merged 1 commit intodotnet:release/dev17.3from
dibarbet:remove_obsolete_api

Conversation

@dibarbet
Copy link
Copy Markdown
Member

@dibarbet dibarbet commented Jun 1, 2022 •
edited
Loading

The old implementation could sometimes throw if there were no actual document changes (results[originalDocument.Id] would not be added to the dictionary in that case). We don't need to access it when they're using the new property, so just remove it.

Exception when processing workflow System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
   at System.ThrowHelper.ThrowKeyNotFoundException()
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at Microsoft.CodeAnalysis.ExternalAccess.IntelliCode.IntentSourceProvider.<ConvertToIntelliCodeResultAsync>d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at Microsoft.CodeAnalysis.ExternalAccess.IntelliCode.IntentSourceProvider.<ComputeIntentsAsync>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at Microsoft.VisualStudio.IntelliCode.Refactorings.Csharp.RefactoringIntent.<GetResultsAsync>d__11.MoveNext()

@dibarbet dibarbet requested a review from a team as a code owner June 1, 2022 17:46
jasonmalinowski
jasonmalinowski approved these changes Jun 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo for actually deleting ExternalAPI stuff!

@dibarbet dibarbet changed the base branch from main to release/dev17.3 June 1, 2022 18:13
@dibarbet dibarbet merged commit 0b0125e into dotnet:release/dev17.3 Jun 1, 2022
@dibarbet dibarbet deleted the remove_obsolete_api branch June 1, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

+1 more reviewer

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Approved to merge Area-IDE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dibarbet @jasonmalinowski @CyrusNajmabadi @vatsalyaagrawal