Skip to content

Add an option to control if compilations are cloned when making skeletons#61613

Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
CyrusNajmabadi:skeletonClone
Jun 1, 2022
Merged

Add an option to control if compilations are cloned when making skeletons#61613
CyrusNajmabadi merged 1 commit intodotnet:mainfrom
CyrusNajmabadi:skeletonClone

Conversation

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

This will allow us to A/B test removing this to see if htere's any impact.

@jasonmalinowski and i were talking, and we think it's unlikely this is providing value. The number of symbols created from top level code should be minor in practice.

@ghost ghost added the Area-IDE label May 31, 2022
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review May 31, 2022 22:45
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner May 31, 2022 22:45
@CyrusNajmabadi CyrusNajmabadi merged commit 74360dc into dotnet:main Jun 1, 2022
@ghost ghost added this to the Next milestone Jun 1, 2022
@RikkiGibson RikkiGibson modified the milestones: Next, 17.3 P3 Jun 28, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the skeletonClone branch July 1, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants