Fix generation location when generating across files#61599
Merged
CyrusNajmabadi merged 3 commits intodotnet:mainfrom May 31, 2022
Merged
Fix generation location when generating across files#61599CyrusNajmabadi merged 3 commits intodotnet:mainfrom
CyrusNajmabadi merged 3 commits intodotnet:mainfrom
Conversation
CyrusNajmabadi
commented
May 31, 2022
| Imports Microsoft.CodeAnalysis.VisualBasic.CodeFixes.GenerateMethod | ||
| Imports Microsoft.CodeAnalysis.Diagnostics | ||
|
|
||
| Namespace Microsoft.CodeAnalysis.Editor.VisualBasic.UnitTests.Diagnostics.GenerateMethod |
Contributor
Author
There was a problem hiding this comment.
extracted these all out into their own file since they were in a nested type.
Contributor
Author
There was a problem hiding this comment.
no other changes here.
CyrusNajmabadi
commented
May 31, 2022
| // Try to strictly obey the before option by inserting immediately before the member containing the location | ||
| if (info.Context.BeforeThisLocation != null) | ||
| if (info.Context.BeforeThisLocation?.SourceTree is { } beforeSourceTree && | ||
| beforeSourceTree == declarationList.FirstOrDefault()?.SyntaxTree) |
Contributor
Author
There was a problem hiding this comment.
these are the fixes. the issue was that we were using the location the user was at in the document they started in to try to pick a location to generate into in the destination document.
Member
There was a problem hiding this comment.
are there any tests that show the before insertion case?
Contributor
Author
There was a problem hiding this comment.
no. in all the "beforeThisLOcation" cases the feature is using the same syntax tree that they're currently in.
0ef8e3a to
c01f5cc
Compare
jmarolf
approved these changes
May 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61542