Skip to content

Add collapsedText to foldingRange#61590

Merged
ryzngard merged 3 commits intodotnet:mainfrom
ryzngard:features/folding_range_collapsed_text
Jun 5, 2022
Merged

Add collapsedText to foldingRange#61590
ryzngard merged 3 commits intodotnet:mainfrom
ryzngard:features/folding_range_collapsed_text

Conversation

@ryzngard
Copy link
Copy Markdown
Contributor

Roslyn already has "BannerText", this just forwards it to the new LSP protocol

@ryzngard ryzngard requested review from a team as code owners May 30, 2022 23:17
@ghost ghost added the Area-IDE label May 30, 2022
@ryzngard ryzngard requested a review from dibarbet May 30, 2022 23:17
Copy link
Copy Markdown
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea about whether this needs to be for main or main-vs-deps, but hopefully the integration tests will tell us

@dibarbet
Copy link
Copy Markdown
Member

No idea about whether this needs to be for main or main-vs-deps, but hopefully the integration tests will tell us

main is fine, we deploy these on F5 and in integration tests because they are just binaries for serialization / deserialization.
https://github.com/dotnet/roslyn/blob/main/src/VisualStudio/Setup.Dependencies/Roslyn.VisualStudio.Setup.Dependencies.csproj#L42

@ryzngard ryzngard enabled auto-merge (squash) May 31, 2022 19:46
@ryzngard ryzngard merged commit a4ed74a into dotnet:main Jun 5, 2022
@ghost ghost added this to the Next milestone Jun 5, 2022
@RikkiGibson RikkiGibson modified the milestones: Next, 17.3 P3 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants