Fixed collection and object initializer usage analysis not working in top-level code by DoctorKrolic · Pull Request #61584 · dotnet/roslyn

DoctorKrolic · 2022-05-29T11:47:47Z

Need help with tests here. Tried to add this test for object initializers:

        [WorkItem(61066, "https://github.com/dotnet/roslyn/issues/61066")]
        [Fact, Trait(Traits.Feature, Traits.Features.CodeActionsUseObjectInitializer)]
        public async Task TestInTopLevelStatements()
        {
            await TestInRegularAndScript1Async(
@"MyClass cl = [|new|]();
cl.MyProperty = 5;

class MyClass
{
    public int MyProperty { get; set; }
}",
@"MyClass cl = new()
{
    MyProperty = 5
}

class MyClass
{
    public int MyProperty { get; set; }
}");
        }

... and got CS8805 compiler error for some reason:

… top-level code

CyrusNajmabadi · 2022-05-29T16:18:27Z

You need to set the output type of the test project to be a consoleapp, not a dll.

DoctorKrolic · 2022-05-29T18:03:00Z

@CyrusNajmabadi Thanks, tests are now done. PR is ready for review

DoctorKrolic · 2022-06-02T17:02:36Z

Can someone review this PR? Thanks in advance

...paces/SharedUtilitiesAndExtensions/Compiler/CSharp/Services/SyntaxFacts/CSharpSyntaxFacts.cs

src/Workspaces/SharedUtilitiesAndExtensions/Compiler/Core/Services/SyntaxFacts/ISyntaxFacts.cs

CyrusNajmabadi · 2022-06-02T17:37:43Z

Done with pass.

src/Analyzers/Core/Analyzers/UseObjectInitializer/UseNamedMemberInitializerAnalyzer.cs

...edUtilitiesAndExtensions/Compiler/VisualBasic/Services/SyntaxFacts/VisualBasicSyntaxFacts.vb

src/Analyzers/Core/Analyzers/UseObjectInitializer/UseNamedMemberInitializerAnalyzer.cs

CyrusNajmabadi · 2022-06-02T20:14:45Z

Done with pass. Only a couple of things to tweak :)

CyrusNajmabadi · 2022-06-02T21:40:57Z

Awesome, thanks!

DoctorKrolic · 2022-06-03T14:04:58Z

@CyrusNajmabadi Approve?)

CyrusNajmabadi · 2022-06-03T14:16:59Z

Yup yup. Thanks :-)

Neme12 · 2022-06-03T14:20:32Z

It's such a shame that global statements have a wrapper node around each individual statement rather than having something like GlobalStatementsSyntax which would then have all the individual statements inside it. This way, it completely breaks the expectation that statements that are next to each other are actually next to each other in the syntax tree and a lot of features are currently broken and have to be specialized to make them work with top level statements 😞

DoctorKrolic · 2022-06-03T14:25:23Z

Fully argree. But I guess it's our life now( Changing this behaviour into something better is too massive breaking change to be made.

CyrusNajmabadi · 2022-06-03T14:32:38Z

We have no cases of an empty nice that is only a wrapper around a SyntaxList. That itself would be an abnormality in the roslyn syntax model.

This upholds the invariant that all nodes have at least one node or token as a direct child.

Fixed collection and object initializer usage analysis not working in…

3d21b2e

… top-level code

DoctorKrolic requested a review from a team as a code owner May 29, 2022 11:47

ghost added Community The pull request was submitted by a contributor who is not a Microsoft employee. Area-IDE and removed Community The pull request was submitted by a contributor who is not a Microsoft employee. labels May 29, 2022

Tests

9a5e8c7