Skip to content

EnC: Allow adding/removing await expressions and yield statements in VB#61569

Merged
tmat merged 6 commits intodotnet:mainfrom
tmat:VBSMEnc
Jun 27, 2022
Merged

EnC: Allow adding/removing await expressions and yield statements in VB#61569
tmat merged 6 commits intodotnet:mainfrom
tmat:VBSMEnc

Conversation

@tmat
Copy link
Copy Markdown
Member

@tmat tmat commented May 27, 2022 •
edited
Loading

Implements #61356 for VB.

Implements #54095

@ghost ghost added the Area-Compilers label May 27, 2022
@tmat tmat force-pushed the VBSMEnc branch 2 times, most recently from 0baf06d to f3f8b64 Compare June 6, 2022 21:09
@tmat tmat marked this pull request as ready for review June 8, 2022 16:28
@tmat tmat requested review from a team as code owners June 8, 2022 16:28
@tmat
Copy link
Copy Markdown
Member Author

tmat commented Jun 8, 2022

@davidwengier PTAL

@tmat
Copy link
Copy Markdown
Member Author

tmat commented Jun 8, 2022

@dotnet/roslyn-compiler

@jcouv jcouv self-assigned this Jun 8, 2022
jcouv
jcouv reviewed Jun 13, 2022
View reviewed changes
jcouv
jcouv reviewed Jun 13, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with review pass of compiler changes (iteration 3)

jcouv
jcouv approved these changes Jun 14, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 4)

@cston
Copy link
Copy Markdown
Contributor

cston commented Jun 23, 2022 

IL_0013:  ldstr      ""Edit and Continue can't resume suspended asynchronous method since the corresponding await expression has been deleted""

CodeAnalysisResources.EncCannotResumeSuspendedAsyncMethod?

Refers to: src/Compilers/VisualBasic/Test/Emit/Emit/EditAndContinue/EditAndContinueStateMachineTests.vb:3057 in 4b70865. [](commit_id = 4b70865, deletion_comment = False)

@cston
Copy link
Copy Markdown
Contributor

cston commented Jun 23, 2022 

    Public Sub UpdateIterator_Yeild_AddRemove_Lambda()

Typo.

Refers to: src/Compilers/VisualBasic/Test/Emit/Emit/EditAndContinue/EditAndContinueStateMachineTests.vb:4551 in 4b70865. [](commit_id = 4b70865, deletion_comment = False)

@tmat tmat merged commit 6f514e4 into dotnet:main Jun 27, 2022
@tmat tmat deleted the VBSMEnc branch June 27, 2022 18:08
@ghost ghost added this to the Next milestone Jun 27, 2022
@RikkiGibson RikkiGibson modified the milestones: Next, 17.3 P3 Jun 28, 2022
@commit-lint commit-lint bot mentioned this pull request Jul 6, 2022
Open
@ryzngard ryzngard mentioned this pull request Jul 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcouv jcouv jcouv approved these changes

+1 more reviewer

@cston cston cston approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jcouv jcouv

Labels

Area-Compilers

Projects

None yet

Milestone

17.3 P3

Development

Successfully merging this pull request may close these issues.

4 participants

@tmat @cston @jcouv @RikkiGibson