Add some APIs on AspNetCoreVirtualCharSequence#61554
Merged
CyrusNajmabadi merged 3 commits intomainfrom May 29, 2022
Merged
Conversation
CyrusNajmabadi
approved these changes
May 27, 2022
| public string CreateString() => _virtualCharSequence.CreateString(); | ||
|
|
||
| /// <inheritdoc cref="VirtualCharSequence.IsDefault"/> | ||
| public bool IsDefault => _virtualCharSequence.IsDefault; |
Contributor
There was a problem hiding this comment.
I'm curious what you need this for @JamesNK . How are you ending up with a default sequence?
Member
Author
There was a problem hiding this comment.
I was using default to create empty sequences. Updated the PR to have a static readonly Empty field instead.
ryzngard
approved these changes
May 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #61529
These are some APIs that either aren't possible, i.e. creating a new sequence via GetSubSequence, or reach into the internals of VirtualCharSequence. This PR exposes them on AspNetCoreVirtualCharSequence.