Update 'Rename's commit behavior to be async.#61549
Merged
CyrusNajmabadi merged 11 commits intodotnet:mainfrom Jun 1, 2022
Merged
Update 'Rename's commit behavior to be async.#61549CyrusNajmabadi merged 11 commits intodotnet:mainfrom
CyrusNajmabadi merged 11 commits intodotnet:mainfrom
Conversation
Contributor
Author
dibarbet
approved these changes
May 31, 2022
| /// <summary> | ||
| /// Dismisses the rename session, completing the rename operation across all files. | ||
| /// </summary> | ||
| [Obsolete($"Use {nameof(CommitAsync)} instead", error: true)] |
Contributor
Author
There was a problem hiding this comment.
nope. i'll just remove :)
| // We pass CancellationToken.None here because we don't have a usable token to pass. The | ||
| // IUIThreadOperationContext passed here as a cancellation token, but the caller in CommitCore has | ||
| // already turned off cancellation because we're committed to the update at this point. If we ever | ||
| // want to pass cancellation here, we'd want to move this part back out of this method and before |
Member
There was a problem hiding this comment.
comment seems off - says we pass None, but we just pass in the callers token
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.