Don't throw in logging when the document path contains curly braces (#61524)#61535
Merged
dibarbet merged 1 commit intodotnet:release/dev17.2from May 31, 2022
Merged
Conversation
ryzngard
approved these changes
May 26, 2022
NTaylorMullen
approved these changes
May 26, 2022
NTaylorMullen
left a comment
There was a problem hiding this comment.
Is there other areas that are potentially at risk here? Also, is there a way to ban the _traceSource.TraceInformation API from LSP based projects?
Member
Author
All our LSP logging code goes through here, so that is covered. I think other issues are probably unlikely- all the roslyn code already handles these documents. And I didn't encounter issues during testing with the Razor LSP server either (the logs show the correct file paths), only when it calls out to roslyn
We can definitely do this. I can send a PR in main to add that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #61524 to 17.2
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1514768
Needs to be backported because this affects Razor - @NTaylorMullen FYI