Skip to content

Update 'Encapsulte Field' to use the new background work indicator.#61531

Merged
CyrusNajmabadi merged 7 commits intodotnet:mainfrom
CyrusNajmabadi:asyncEncapsulateField
May 26, 2022
Merged

Update 'Encapsulte Field' to use the new background work indicator.#61531
CyrusNajmabadi merged 7 commits intodotnet:mainfrom
CyrusNajmabadi:asyncEncapsulateField

Conversation

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

Looks like this:

image

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner May 26, 2022 16:24
@ghost ghost added the Area-IDE label May 26, 2022
return false;

// Fire and forget
var token = _listener.BeginAsyncOperation("EncapsulateField");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not have a FeatureAttribute constant here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ick. let me add.

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge May 26, 2022 16:59
@CyrusNajmabadi CyrusNajmabadi merged commit 1db7eeb into dotnet:main May 26, 2022
@ghost ghost added this to the Next milestone May 26, 2022
@CyrusNajmabadi CyrusNajmabadi deleted the asyncEncapsulateField branch May 26, 2022 19:55
@Cosifne Cosifne modified the milestones: Next, 17.3 P2 May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants